Skip to content

Commit eeef4e9

Browse files
authored
Remove smoke test check for SSL support, let the defaults works (#3259)
# Description of Changes As title says # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing - [x] Run smoke test
1 parent d0d99b9 commit eeef4e9

1 file changed

Lines changed: 2 additions & 14 deletions

File tree

smoketests/tests/pg_wire.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,12 @@
55
import psycopg2
66

77

8-
def psql(identity: str, sql: str, extra=None) -> str:
8+
def psql(identity: str, sql: str) -> str:
99
"""Call `psql` and execute the given SQL statement."""
10-
if extra is None:
11-
extra = dict()
1210
result = subprocess.run(
1311
["psql", "-h", "127.0.0.1", "-p", "5432", "-U", "postgres", "-d", "quickstart", "--quiet", "-c", sql],
1412
encoding="utf8",
15-
env={**os.environ, **extra, "PGPASSWORD": identity},
13+
env={**os.environ, "PGPASSWORD": identity},
1614
stdout=subprocess.PIPE,
1715
stderr=subprocess.PIPE,
1816
text=True,
@@ -267,16 +265,6 @@ def test_failures(self):
267265
sql_out = psql(token, "")
268266
self.assertEqual(sql_out, "")
269267

270-
# Connection fails when `ssl` is required
271-
for ssl_mode in ["require", "verify-ca", "verify-full"]:
272-
with self.assertRaises(Exception) as cm:
273-
psql(token, "SELECT * FROM t_uints", extra={"PGSSLMODE": ssl_mode})
274-
self.assertIn("not support SSL", str(cm.exception))
275-
276-
# But works with `ssl` is disabled or optional
277-
for ssl_mode in ["disable", "allow", "prefer"]:
278-
psql(token, "SELECT * FROM t_uints", extra={"PGSSLMODE": ssl_mode})
279-
280268
# Connection fails with invalid token
281269
with self.assertRaises(Exception) as cm:
282270
psql("invalid_token", "SELECT * FROM t_uints")

0 commit comments

Comments
 (0)