more simplification

Author: joshua-spacetime

crates/execution/src/lib.rs

@@ -16,12 +16,12 @@ pub mod pipelined;
 
 #[derive(Debug, Clone, Copy)]
 pub struct ExecutionParams {
-    sender: Option<Identity>,
+    sender: Identity,
 }
 
 impl ExecutionParams {
     pub fn from_sender(sender: Identity) -> Self {
-        Self { sender: Some(sender) }
+        Self { sender }
     }
 
     pub fn from_auth(auth: &AuthCtx) -> Self {
@@ -32,13 +32,8 @@ impl ExecutionParams {
 impl ParamResolver for ExecutionParams {
     fn resolve_param(&self, param: Parameter, ty: &AlgebraicType) -> AlgebraicValue {
         match param {
-            Parameter::Sender if ty.is_identity() => self.sender.expect("missing sender binding for :sender").into(),
-            Parameter::Sender if ty.is_bytes() => AlgebraicValue::Bytes(
-                self.sender
-                    .expect("missing sender binding for :sender")
-                    .to_be_byte_array()
-                    .into(),
-            ),
+            Parameter::Sender if ty.is_identity() => self.sender.into(),
+            Parameter::Sender if ty.is_bytes() => AlgebraicValue::Bytes(self.sender.to_be_byte_array().into()),
             Parameter::Sender => panic!("unsupported type for :sender: {ty:?}"),
         }
     }

crates/physical-plan/src/plan.rs

@@ -36,14 +36,6 @@ pub trait ParamResolver {
     fn resolve_param(&self, param: Parameter, ty: &AlgebraicType) -> AlgebraicValue;
 }
 
-struct NoParams;
-
-impl ParamResolver for NoParams {
-    fn resolve_param(&self, param: Parameter, _: &AlgebraicType) -> AlgebraicValue {
-        panic!("unbound query parameter: {param:?}")
-    }
-}
-
 /// Physical plans always terminate with a projection.
 /// This type of projection returns row ids.
 ///
@@ -1493,19 +1485,6 @@ impl PhysicalExpr {
         }
     }
 
-    /// Evaluate this boolean expression over `row`
-    pub fn eval_bool(&self, row: &impl ProjectField) -> bool {
-        self.eval(row).as_bool().copied().unwrap_or(false)
-    }
-
-    /// Evaluate this boolean expression over `row`
-    pub fn eval_bool_with_metrics(&self, row: &impl ProjectField, bytes_scanned: &mut usize) -> bool {
-        self.eval_with_metrics(row, bytes_scanned)
-            .as_bool()
-            .copied()
-            .unwrap_or(false)
-    }
-
     /// Evaluate this boolean expression over `row` with runtime parameters.
     pub fn eval_bool_with_params(
         &self,
@@ -1519,16 +1498,6 @@ impl PhysicalExpr {
             .unwrap_or(false)
     }
 
-    /// Evaluate this expression over `row`
-    fn eval(&self, row: &impl ProjectField) -> Cow<'_, AlgebraicValue> {
-        self.eval_with_metrics(row, &mut 0)
-    }
-
-    /// Evaluate this expression over `row`
-    pub fn eval_with_metrics(&self, row: &impl ProjectField, bytes_scanned: &mut usize) -> Cow<'_, AlgebraicValue> {
-        self.eval_with_params(row, &NoParams, bytes_scanned)
-    }
-
     /// Evaluate this expression over `row` with runtime parameters.
     pub fn eval_with_params<'a>(
         &'a self,