Skip to content

Commit f4a9819

Browse files
authored
CI - DOCKERHUB_PASSWORD -> DOCKERHUB_TOKEN (#5096)
# Description of Changes Updating workflows to use a new secret # API and ABI breaking changes None. CI only. # Expected complexity level and risk 1 # Testing - [x] the `unity-testsuite` CI still passes - [x] a test release successfully pushed an image (<https://github.com/clockworklabs/SpacetimeDB/actions/runs/26262521745>) --------- Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
1 parent 4b46617 commit f4a9819

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -689,12 +689,6 @@ jobs:
689689
key: Unity-${{ github.head_ref }}
690690
restore-keys: Unity-
691691

692-
- name: Login to DockerHub
693-
uses: docker/login-action@v2
694-
with:
695-
username: ${{ vars.DOCKERHUB_USERNAME }}
696-
password: ${{ secrets.DOCKERHUB_PASSWORD }}
697-
698692
- name: Run Unity tests
699693
uses: game-ci/unity-test-runner@v4
700694
with:

.github/workflows/docker.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ jobs:
4040
uses: docker/login-action@v2
4141
with:
4242
username: ${{ vars.DOCKERHUB_USERNAME }}
43-
password: ${{ secrets.DOCKERHUB_PASSWORD }}
43+
# Docker Hub access tokens are passed to docker/login-action via the password input.
44+
password: ${{ secrets.DOCKERHUB_TOKEN }}
4445
- name: Build and push
4546
uses: docker/build-push-action@v4
4647
with:
@@ -101,7 +102,8 @@ jobs:
101102
uses: docker/login-action@v2
102103
with:
103104
username: ${{ vars.DOCKERHUB_USERNAME }}
104-
password: ${{ secrets.DOCKERHUB_PASSWORD }}
105+
# Docker Hub access tokens are passed to docker/login-action via the password input.
106+
password: ${{ secrets.DOCKERHUB_TOKEN }}
105107
- name: Build and push
106108
uses: docker/build-push-action@v4
107109
with:

.github/workflows/tag-release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ jobs:
1414
uses: docker/login-action@v2
1515
with:
1616
username: ${{ vars.DOCKERHUB_USERNAME }}
17-
password: ${{ secrets.DOCKERHUB_PASSWORD }}
17+
# Docker Hub access tokens are passed to docker/login-action via the password input.
18+
password: ${{ secrets.DOCKERHUB_TOKEN }}
1819

1920
- name: Retag the image
2021
run: |

0 commit comments

Comments
 (0)