Merge branch 'master' into onx2/table-traits

Author: bfops

.cargo/config.toml

@@ -2,9 +2,9 @@
 rustflags = ["--cfg", "tokio_unstable"]
 
 [alias]
-bump-versions = "run -p upgrade-version --"
 llm = "run --package xtask-llm-benchmark --bin llm_benchmark --"
 ci = "run -p ci --"
+regen = "run -p regen --"
 smoketest = "ci smoketests --"
 smoketests = "smoketest"
 lint = "ci lint --"

.gitattributes

@@ -1,3 +1,4 @@
 **/module_bindings/** linguist-generated=true eol=lf
+**/ModuleBindings/** linguist-generated=true eol=lf
 /docs/llms/** linguist-generated=true
 /docs/llms/*-details.json linguist-generated=false

.github/CODEOWNERS

@@ -7,6 +7,7 @@ LICENSE.txt @cloutiertyler
 
 /crates/cli/src/ @bfops @cloutiertyler @jdetter
 /tools/ci/ @bfops @cloutiertyler @jdetter
+/tools/ci/src/keynote_bench.rs @joshua-spacetime @cloutiertyler @jdetter
 /tools/upgrade-version/ @bfops @jdetter @cloutiertyler
 /tools/license-check/ @bfops @jdetter @cloutiertyler
 /.github/ @bfops @jdetter @cloutiertyler

.github/actions/keynote-bench-setup/action.yml

@@ -0,0 +1,49 @@
+name: Keynote Bench Setup
+description: Shared setup for the keynote benchmark job
+
+inputs:
+  public_root:
+    description: Path to the public SpacetimeDB checkout in the caller workspace
+    required: false
+    default: .
+  rust_cache_workspaces:
+    description: Workspace paths passed to Swatinem/rust-cache
+    required: true
+
+runs:
+  using: composite
+  steps:
+    - uses: dsherret/rust-toolchain-file@v1
+
+    - name: Set default rust toolchain
+      shell: bash
+      run: rustup default $(rustup show active-toolchain | cut -d' ' -f1)
+
+    - name: Cache Rust dependencies
+      uses: Swatinem/rust-cache@v2
+      with:
+        workspaces: ${{ inputs.rust_cache_workspaces }}
+        shared-key: spacetimedb
+        save-if: false
+        prefix-key: v1
+
+    - name: Check v8 outputs
+      shell: bash
+      run: |
+        find "${CARGO_TARGET_DIR}"/ -type f | grep '[/_]v8' || true
+        if ! [ -f "${CARGO_TARGET_DIR}"/release/gn_out/obj/librusty_v8.a ]; then
+          echo "Could not find v8 output file librusty_v8.a; rebuilding manually."
+          cargo clean --release -p v8 || true
+          cargo build --release -p v8
+        fi
+      working-directory: ${{ inputs.public_root }}
+
+    - name: Build public keynote benchmark binaries
+      shell: bash
+      run: cargo build --release -p spacetimedb-cli -p spacetimedb-standalone
+      working-directory: ${{ inputs.public_root }}
+
+    - name: Build TypeScript SDK
+      shell: bash
+      run: pnpm build
+      working-directory: ${{ inputs.public_root }}/crates/bindings-typescript

.github/actions/setup-pnpm/action.yml

@@ -0,0 +1,31 @@
+name: Set up pnpm
+description: Install pnpm and configure repository package-age policy before any install
+inputs:
+  package_json_file:
+    description: package.json file used to determine the pnpm version
+    required: false
+    default: package.json
+  run_install:
+    description: Run pnpm install after configuring pnpm
+    required: false
+    default: "false"
+  working_directory:
+    description: Directory to run pnpm install in
+    required: false
+    default: .
+runs:
+  using: composite
+  steps:
+    - uses: pnpm/action-setup@v4
+      with:
+        package_json_file: ${{ inputs.package_json_file }}
+
+    - name: Configure pnpm package age policy
+      shell: bash
+      run: pnpm config set --global minimumReleaseAge 1440
+
+    - name: Install dependencies
+      if: inputs.run_install == 'true'
+      shell: bash
+      working-directory: ${{ inputs.working_directory }}
+      run: pnpm install

.github/docker-compose.yml

@@ -17,10 +17,10 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Download artifacts from private base URL
+      - name: Download artifacts from AWS base URL
         env:
           RELEASE_TAG: ${{ github.event.inputs.release_tag }}
-          BASE_URL: ${{ secrets.ARTIFACT_BASE_URL }}
+          BASE_URL: https://${{ vars.AWS_BUCKET }}.s3.amazonaws.com/refs/tags
         run: |
           set -euo pipefail
 

.github/workflows/attach-artifacts.yml

@@ -2,7 +2,6 @@ on:
   push:
     branches:
       - master
-      - jgilles/fix-callgrind-again
 
   workflow_dispatch:
     inputs:
@@ -24,8 +23,10 @@ jobs:
   benchmark:
     name: run criterion benchmarks
     runs-on: benchmarks-runner
+    # disable until we fix the benchmarks
+    if: false
     # filter for a comment containing 'benchmarks please'
-    if: ${{ github.event_name != 'issue_comment' || (github.event.issue.pull_request && contains(github.event.comment.body, 'benchmarks please')) }}
+    #if: ${{ github.event_name != 'issue_comment' || (github.event.issue.pull_request && contains(github.event.comment.body, 'benchmarks please')) }}
     env:
       PR_NUMBER: ${{ github.event.inputs.pr_number || github.event.issue.number || null }}
     steps:
@@ -185,8 +186,10 @@ jobs:
     container:
       image: rust:1.93.0
       options: --privileged
+    # disable until we fix the benchmarks
+    if: false
     # filter for a comment containing 'benchmarks please'
-    if: ${{ github.event_name != 'issue_comment' || (github.event.issue.pull_request && contains(github.event.comment.body, 'benchmarks please')) }}
+    #if: ${{ github.event_name != 'issue_comment' || (github.event.issue.pull_request && contains(github.event.comment.body, 'benchmarks please')) }}
     env:
       PR_NUMBER: ${{ github.event.inputs.pr_number || github.event.issue.number || null }}
     steps: