Skip to content

Fix to Unreal tests to stop requesting infinite resources#3504

Merged
JasonAtClockwork merged 1 commit into
masterfrom
jlarabie/unreal-setrlimit
Oct 28, 2025
Merged

Fix to Unreal tests to stop requesting infinite resources#3504
JasonAtClockwork merged 1 commit into
masterfrom
jlarabie/unreal-setrlimit

Conversation

@JasonAtClockwork
Copy link
Copy Markdown
Contributor

Description of Changes

For core dumps Unreal tries to use setrlimit() for infinity when setting resource limits, it seems this becomes an issue intermittently when running tests in parallel. There is an option when running Unreal to disable this and we can rely on error longs only which makes sense for CI imo.

API and ABI breaking changes

None

Expected complexity level and risk

1 - small flag change

Testing

  • Re-ran all tests locally

@JasonAtClockwork JasonAtClockwork self-assigned this Oct 27, 2025
@JasonAtClockwork JasonAtClockwork added bugfix Fixes something that was expected to work differently backward-compatible labels Oct 27, 2025
@bfops
Copy link
Copy Markdown
Collaborator

bfops commented Oct 27, 2025

Does that mean that we only see the setrlimit error when something else has already gone wrong?

@JasonAtClockwork
Copy link
Copy Markdown
Contributor Author

Does that mean that we only see the setrlimit error when something else has already gone wrong?

This is actually before anything has run in Unreal, on the Linux initialization it runs a IncreasePerProcessLimits() before allowing the internal GuardedMain() from processing. It does mean we won't get Unreal core dumps if something goes wrong in CI but if it goes that badly wrong with a test we should see it in a lower environment first. It will still output all errors that happened which is 90% of the time enough to resolve any troubles.

Copy link
Copy Markdown
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, SGTM!

@JasonAtClockwork JasonAtClockwork marked this pull request as ready for review October 28, 2025 19:39
@JasonAtClockwork JasonAtClockwork added this pull request to the merge queue Oct 28, 2025
Merged via the queue into master with commit 3db42a7 Oct 28, 2025
28 checks passed
@bfops bfops deleted the jlarabie/unreal-setrlimit branch May 6, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backward-compatible bugfix Fixes something that was expected to work differently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants