[TS] fix connectionBuilder wrong codegen type.#3795
Closed
kistz wants to merge 1 commit into
Closed
Conversation
Contributor
|
This changes doesn't make sense to me.
What type error were you getting? |
Contributor
Author
Contributor
|
I am fairly certain this is fixed by my own PR. Just want to find the PR before I close this. |
Contributor
|
Closing as this is now resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description of Changes
When trying to use the react hook and you supply a DbConnectionBuilder to
connectionBuilder={builder}from your module bindings typescript throws a type error since the codegeneration type for the generic field is wrong.With
bun devthis error lets you still build the application and view it but with a production build it hard errors.Fix it by changing the codegen to use the right interface instead of a hardcoded
DbConnectiontype that isn't even present in the file and should come from the module_bindings.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing