Implemented RETURNING support for SQL#3935
Open
egormanga wants to merge 3 commits into
Open
Conversation
egormanga
force-pushed
the
sql-returning
branch
from
aa6d63d to
bd0c289
Compare
Collaborator
|
Thank you for filing this! We'll work on getting a reviewer on it. |
Contributor
|
Going to get someone to review this. |
joshua-spacetime
left a comment
joshua-spacetime
left a comment
Contributor
There was a problem hiding this comment.
I think this is a good feature to add. I'd just like to see some tests. In particular I think the following tests would either fail or wrongly succeed today:
UPDATE a SET ... RETURNING a.*;
UPDATE a SET ... RETURNING count(*) AS n;
| ( | ||
| SqlResult { | ||
| tx_offset: tx_offset_receiver, | ||
| rows: vec![], |
Contributor
There was a problem hiding this comment.
Suggested change
| rows, |
This is the other possible return branch.
| let returning = returning | ||
| .map(|proj| type_proj(RelExpr::RelVar(Relvar { | ||
| schema: schema, | ||
| alias: ST_VAR_NAME.into(), |
Contributor
There was a problem hiding this comment.
This alias should be the insert table.
| let returning = returning | ||
| .map(|proj| type_proj(RelExpr::RelVar(Relvar { | ||
| schema: from.clone(), | ||
| alias: ST_VAR_NAME.into(), |
Contributor
There was a problem hiding this comment.
This should be the delete table.
| let returning = returning | ||
| .map(|proj| type_proj(RelExpr::RelVar(Relvar { | ||
| schema: schema.clone(), | ||
| alias: ST_VAR_NAME.into(), |
Contributor
There was a problem hiding this comment.
Similarly this should be the update table.
| table: parse_ident(table_name)?, | ||
| fields: columns.into_iter().map(SqlIdent::from).collect(), | ||
| values: parse_values(*source)?, | ||
| returning: returning.map(parse_projection).transpose()?, |
Contributor
There was a problem hiding this comment.
I believe parse_projection allows for aggregate expressions like COUNT, not valid in RETURNING.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
SQL
RETURNINGfor DML to return affected rows to the caller:gives:
(same goes for
UPDATE&DELETE).Individual columns can be specified, too — separately from the fields the statement operates on:
allowing to efficiently combine DML with implicit
SELECTs.API and ABI breaking changes
None.
Expected complexity level and risk
2.
Testing