Fixed rename by using put instead of post#2764
Merged
Merged
Conversation
bfops
reviewed
May 21, 2025
Collaborator
|
@cloutiertyler I updated the code meaningfully, as well as augmenting the smoketest. The new endpoint just returns a string that's either |
cloutiertyler
commented
May 21, 2025
…ckworklabs/SpacetimeDB into tyler/fix-rename
Collaborator
|
(status here: the smoketests have uncovered that the |
Collaborator
|
To clarify, you cannot clobber a database that you do not own: |
bfops
approved these changes
Jun 11, 2025
Collaborator
bfops
left a comment
There was a problem hiding this comment.
LGTM. Idk why I had to change it to parse a non-JSON response at one point, but it does seem to consistently return JSON responses now, so.. 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #2763
API and ABI breaking changes
Technically a breaking change because it changes the behavior of the CLI, but it's arguably a bug fix.
Expected complexity level and risk
2 because of the breaking nature
Testing