TimeSpan-Style TimeDuration Constructors in C# Bindings#2778
Merged
bfops merged 7 commits intoAug 15, 2025
Conversation
… user familiarity.
Collaborator
|
Thank you for submitting this! We'll work on getting it reviewed soon. |
Contributor
Author
|
Thanks! Feel free to merge as-is if you have no problems with it on review. Also very happy to add the equivalent construction helper methods to the |
Contributor
Author
|
Hello! Just wanted to bump this as it's been a couple months now on what seems like a fairly minor edit. :) |
rekhoff
approved these changes
Aug 15, 2025
Contributor
rekhoff
left a comment
There was a problem hiding this comment.
These changes look reasonable and and clear.
Collaborator
|
I'm going to force-merge this since the only CI checks that haven't run/passed are from the public repos that we merged in. This PR is from before we merged them, so it can't mess them up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This change adds the following
System.TimeSpan-style static construction methods toSpacetimeDB.TimeDuration:static TimeDuration FromMilliseconds(double milliseconds)static TimeDuration FromSeconds(double seconds)static TimeDuration FromMinutes(double minutes)static TimeDuration FromHours(double hours)static TimeDuration FromDays(double days)These mirror the equivalently named static methods on
System.TimeSpanand dramatically improve usability and familiarity for experienced C# users with no more overhead than the user performing the multiplication themselves.Wish I'd thought to do this before v1.1.2 got released. Ah well.
API and ABI breaking changes
None. Convenience methods added in bindings only.
Expected complexity level and risk
1 (potentially up to a low 2 if cleanup is desired elsewhere in the bindings to leverage these new methods).
Testing