Pin db threads to cores#2801
Merged
Merged
Conversation
ebdba32 to
6b71990
Compare
6b71990 to
f46b4e9
Compare
8b10d15 to
519de4d
Compare
519de4d to
72e4e56
Compare
gefjon
reviewed
Jun 3, 2025
Contributor
Author
|
Ah. I think the failure is possibly because |
gefjon
reviewed
Jun 6, 2025
Co-authored-by: Phoebe Goldman <phoebe@clockworklabs.io> Signed-off-by: Noa <coolreader18@gmail.com>
gefjon
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This pins the threads that wasm instances run on, tokio worker threads, and rayon threads to specific cores, in the following arrangement:
nproc/8databases running, all the database cores will have roughly the same number of instances pinned to them.tokio::runtime::Builder::num_threadsset to the same number.sched_setaffinityset to a cpuset of the remaining 3/8.API and ABI breaking changes
Expected complexity level and risk
Testing