Page::reset_for: stop zeroing pages#2804
Merged
Merged
Conversation
joshua-spacetime
approved these changes
May 28, 2025
| // If we ever decide to add such an ABI, we must start zeroing again. | ||
| // | ||
| // // SAFETY: We just reset the page header. | ||
| // unsafe { self.zero_data() }; |
Contributor
There was a problem hiding this comment.
We do not need to zero pages as long as the pages aren't shared between modules. If the page pool is specific to a single tenant, we're okay.
Contributor
Author
There was a problem hiding this comment.
That's true, but in our current setup, we do share pages between modules.
Contributor
There was a problem hiding this comment.
The page pool is very much global right now. We don't currently expose pages' raw bytes to customers, as we don't expose a way to download snapshots nor have a raw page ABI for modules. We would like to do both of those things in the future, though, and so we'll need to either revert this change, or make it configurable. I'll make a ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #2803.
API and ABI breaking changes
None
Expected complexity level and risk
The main risk here is that if we continue doing this, we have to give up
Testing
Any semantically meaningful logic should be covered by existing tests.