client-api: Don't debug-print dropped outgoing Ws messages at info#2819
Merged
Conversation
It's not impossible for a client to disconnect while there are outstanding subscription messages (e.g. `st_client` updates), and printing them all to the log at info level just creates a lot of data with limited value. Print them at debug level instead.
gefjon
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not impossible for a client to disconnect while there are outstanding subscription messages (e.g.
st_clientupdates), and printing them all to the log at info level just creates a lot of data with limited value.Print them at debug level instead.
Expected complexity level and risk
1
Testing
Just a log verbosity change.