Skip to content

client-api: Don't debug-print dropped outgoing Ws messages at info #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kim merged 1 commit into from
Jun 11, 2025
Merged

client-api: Don't debug-print dropped outgoing Ws messages at info #2819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/client-api/src/routes/subscribe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,8 @@ async fn ws_client_actor_inner(
// TODO: this isn't great. when we receive a close request from the peer,
// tungstenite doesn't let us send any new messages on the socket,
// even though the websocket RFC allows it. should we fork tungstenite?
log::info!("dropping messages due to ws already being closed: {:?}", &rx_buf[..n]);
log::info!("dropping {n} messages due to ws already being closed");
log::debug!("dropped messages: {:?}", &rx_buf[..n]);
} else {
let send_all = async {
for msg in rx_buf.drain(..n) {
Expand Down
Loading