Skip to content

Prune more queries when evaluating subscription updates#2855

Merged
joshua-spacetime merged 4 commits into
masterfrom
joshua/perf/more-query-pruning-for-joins
Jun 14, 2025
Merged

Prune more queries when evaluating subscription updates#2855
joshua-spacetime merged 4 commits into
masterfrom
joshua/perf/more-query-pruning-for-joins

Conversation

@joshua-spacetime

@joshua-spacetime joshua-spacetime commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

Description of Changes

If a table is subscribed to, and it joins with many different tables, this optimization will attempt to prune joins that it knows are empty.

API and ABI breaking changes

None

Expected complexity level and risk

3

A bug will most likely result in incorrect subscription results

Testing

  • Internal tests
  • Performance tests

@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/more-query-pruning-for-joins branch from 8e0b0b6 to e44323e Compare June 12, 2025 02:27
@joshua-spacetime joshua-spacetime marked this pull request as ready for review June 12, 2025 02:28
@joshua-spacetime joshua-spacetime requested a review from mamcx June 12, 2025 02:28
@joshua-spacetime joshua-spacetime self-assigned this Jun 12, 2025
Comment thread crates/core/src/subscription/module_subscription_manager.rs Outdated
Comment thread crates/core/src/subscription/module_subscription_manager.rs Outdated
Comment thread crates/subscription/src/lib.rs Outdated
joshua-spacetime and others added 2 commits June 12, 2025 12:55
Co-authored-by: Mario Montoya <mamcx@elmalabarista.com>
Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
@joshua-spacetime joshua-spacetime requested a review from mamcx June 12, 2025 19:59

@mamcx mamcx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-spacetime joshua-spacetime added this pull request to the merge queue Jun 14, 2025
Merged via the queue into master with commit c522c0f Jun 14, 2025
19 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/perf/more-query-pruning-for-joins branch June 14, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants