Remove incorrect const qualifiers on two imports in bindings.c#2862
Merged
Conversation
`datastore_insert_bsatn` and `datastore_update_bsatn` will write back to the row buffer when passed a row with a 0 in an `auto_inc` column. The Rust imports correctly specify these row pointers as `*mut u8`, but the C# imports in `bindings.c` were declaring them as `const uint8_t*`. This commit removes the incorrect `const` qualifiers from the row pointer arguments in those declarations.
Centril
approved these changes
Jun 16, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Yep, these are morally &mut [u8]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
datastore_insert_bsatnanddatastore_update_bsatnwill write back to the row buffer when passed a row with a 0 in anauto_inccolumn. The Rust imports correctly specify these row pointers as*mut u8, but the C# imports inbindings.cwere declaring them asconst uint8_t*. This commit removes the incorrectconstqualifiers from the row pointer arguments in those declarations.API and ABI breaking changes
N/a
Expected complexity level and risk
1
Testing
N/a