Record the size of a client's outgoing message queue on drop#2877
Merged
joshua-spacetime merged 3 commits intoJun 18, 2025
Conversation
gefjon
reviewed
Jun 18, 2025
gefjon
approved these changes
Jun 18, 2025
joshua-spacetime
force-pushed
the
joshua/fix/outgoing-client-message-queue
branch
from
3993ba2 to
f3c0634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
If a client's send queue reaches
CLIENT_CHANNEL_CAPACITY, we drop the client connection by aborting the task that sends and receives messages from the client. If this abort happens before the task pulls the last messages off the queue, the outgoing queue length metric will never be decremented appropriately.To fix this, we wrap the message receiver with the metric and decrement the metric when we drop the receiver. The receiver's
Dropmethod will be called when the future is aborted which will now decrement the metric appropriately.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
TBD