Speed up metadata update on unsubscribe#2880
Merged
joshua-spacetime merged 1 commit intoJun 20, 2025
Merged
Conversation
bfops
pushed a commit
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Performance tests showed a disproportionate amount of time being spent updating subscription metadata for unsubscribe vs subscribe. This was due to multiple scans of the search argument map in
remove_multi_subscription. This patch replaces those scans, such as those performed byretain, with key lookups into the map.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
This is a refactor and so previous test coverage still applies.