Skip to content

Track disconnects initiated by the client#2893

Merged
joshua-spacetime merged 2 commits into
masterfrom
joshua/track-ws-close-frame
Jun 25, 2025
Merged

Track disconnects initiated by the client#2893
joshua-spacetime merged 2 commits into
masterfrom
joshua/track-ws-close-frame

Conversation

@joshua-spacetime
Copy link
Copy Markdown
Contributor

Description of Changes

When a client connection ends, we want to know who initiated the disconnect - the client or the server.

API and ABI breaking changes

None

Expected complexity level and risk

0

Testing

Copy link
Copy Markdown
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Some minor tweaks and I think this will be good to merge.

Comment thread crates/client-api/src/routes/subscribe.rs
Comment thread crates/core/src/worker_metrics/mod.rs Outdated
@joshua-spacetime joshua-spacetime force-pushed the joshua/track-ws-close-frame branch from a76b726 to 177e38e Compare June 25, 2025 23:08
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Jun 25, 2025
Merged via the queue into master with commit 28186d8 Jun 25, 2025
19 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/track-ws-close-frame branch June 25, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants