Skip to content

Track disconnects initiated by the client #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshua-spacetime merged 2 commits into from
Jun 25, 2025
Merged

Track disconnects initiated by the client #2893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4592893
Track disconnects initiated by the client
joshua-spacetime Jun 24, 2025
177e38e
update help message
joshua-spacetime Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion crates/client-api/src/routes/subscribe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,15 @@ async fn ws_client_actor_inner(

// if this is the closed-by-them case, let the ClientConnectionSenders know now.
sendrx.close();
closed = true;
log::trace!("Close frame {:?}", close_frame);
if !closed {
// This is the client telling us they want to close.
WORKER_METRICS
.ws_clients_closed_connection
.with_label_values(&addr)
Comment thread
joshua-spacetime marked this conversation as resolved.
.inc();
}
closed = true;
}
}
}
Expand Down
7 changes: 6 additions & 1 deletion crates/core/src/worker_metrics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,15 @@ metrics_group!(
pub ws_clients_spawned: IntGaugeVec,

#[name = spacetime_worker_ws_clients_aborted]
#[help = "Number of ws client connections aborted"]
#[help = "Number of ws client connections aborted by either the server or the client"]
#[labels(database_identity: Identity)]
pub ws_clients_aborted: IntGaugeVec,

#[name = spacetime_worker_ws_clients_closed_connection]
#[help = "Number of ws client connections closed by the client as opposed to being termiated by the server"]
#[labels(database_identity: Identity)]
pub ws_clients_closed_connection: IntGaugeVec,

#[name = spacetime_websocket_requests_total]
#[help = "The cumulative number of websocket request messages"]
#[labels(database_identity: Identity, protocol: str)]
Expand Down
Loading