messages::serialize: use 8 KiB for tx update compression threshold#2902
Closed
Centril wants to merge 2 commits into
Closed
messages::serialize: use 8 KiB for tx update compression threshold#2902Centril wants to merge 2 commits into
messages::serialize: use 8 KiB for tx update compression threshold#2902Centril wants to merge 2 commits into
Conversation
Centril
changed the title
messages::serialize: use 8 KiB for tx update compression threshold
bfops
added
release-any
Contributor
|
Closing this for now, but we can always revisit in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Set the compression threshold to 8KiB for transaction updates, keeping the lower 1KiB for initial subs.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Needs to be perf tested manually.