(perf) send_one_computed_queries: reuse aggregation HashMaps#2909
Merged
Centril merged 2 commits intoJun 27, 2025
Conversation
gefjon
approved these changes
Jun 27, 2025
joshua-spacetime
pushed a commit
that referenced
this pull request
Jun 27, 2025
joshua-spacetime
pushed a commit
that referenced
this pull request
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Store the aggregation
HashMaps inSendWorkerin-between doingsend_one_computed_queries.The latest region 9 flamegraph shows that most of
send_one_computed_queriesis spent allocating hash maps.That's wasted work, as we can simply reuse the same two hash maps again and again.
API and ABI breaking changes
None
Expected complexity level and risk
1, local and fairly simple change.
Testing
Covered by existing tests.
Reviewer notes
Hide those whitespace changes!