Fix equality comparison between Row::Ptr and Row::Ref#2914
Merged
Conversation
Centril
approved these changes
Jul 3, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Ah yeah; this impl exists for RelValue but it seems it didn't make it to Row.
I agree it would be good to add a test though, so let's merge when that is in.
Centril
reviewed
Jul 3, 2025
Contributor
|
I think assert_tx_update_for_table(&mut rx, u_id, &schema, [], []).await;because the transaction no longer returns any row updates, so you can remove this check. |
joshua-spacetime
approved these changes
Jul 3, 2025
Contributor
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
We should have already had test coverage for this, but unfortunately the test in question was broken. It's fixed now though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The derived
PartialEqalways considersPtrandRefto be different, even if the values are the same.This fixes the errors from this repro.
Expected complexity level and risk
Testing
Some more direct testing would be nice, but being able to create
Rows is not that easy. Right now this has some indirect code coverage, since it broke some tests.