Skip to content

Fix equality comparison between Row::Ptr and Row::Ref #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsdt merged 5 commits into from
Jul 7, 2025
Merged

Fix equality comparison between Row::Ptr and Row::Ref #2914

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09ad71c
Fix equality comparison between Row::Ptr and Row::Ref
jsdt Jul 3, 2025
d7d7dd9
Merge branch 'master' into jsdt/row-eq
jsdt Jul 3, 2025
eb02fe0
Update test
jsdt Jul 3, 2025
d008520
fix broken test
joshua-spacetime Jul 3, 2025
e70922a
Merge branch 'master' into jsdt/row-eq
jsdt Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion crates/execution/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,25 @@ pub trait DeltaStore {
}
}

#[derive(Clone, PartialEq, Eq)]
#[derive(Clone)]
Comment thread
jsdt marked this conversation as resolved.
pub enum Row<'a> {
Ptr(RowRef<'a>),
Ref(&'a ProductValue),
}

impl PartialEq for Row<'_> {
fn eq(&self, other: &Self) -> bool {
match (self, other) {
(Self::Ptr(x), Self::Ptr(y)) => x == y,
(Self::Ref(x), Self::Ref(y)) => x == y,
(Self::Ptr(x), Self::Ref(y)) => x == *y,
(Self::Ref(x), Self::Ptr(y)) => y == *x,
}
}
}

impl Eq for Row<'_> {}

impl Hash for Row<'_> {
fn hash<H: Hasher>(&self, state: &mut H) {
match self {
Expand Down
Loading