cli: Close the websocket connection gracefully#2925
Merged
Conversation
The `subscribe` command would drop the connection without sending a close frame. Doing so creates a warning on the server, which can be distracting when debugging other connections issues.
bfops
reviewed
Jul 7, 2025
Collaborator
|
It looks like the tests are failing. I tried re-running, but it may be an actual failure. I haven't looked into why. |
bfops
added
release-any
Contributor
Author
|
Ah well, missed the case where the server closes the connection. |
Collaborator
|
@kim looks like it's still failing? |
Contributor
Author
|
meh |
bfops
reviewed
Jul 21, 2025
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
I haven't carefully reviewed the new Error type variants, but the rest of the code that constructs them seems fine. It's fine if the error messages changed a bit or something.
A couple of small questions
bfops
approved these changes
Jul 22, 2025
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
This PR LGTM. I haven't done any testing.
There's still one unresolved comment thread, that you can resolve however makes sense to you and then merge. 🚢
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
The `subscribe` command would drop the connection without sending a close frame. Doing so creates a warning on the server, which can be distracting when debugging other connections issues. # Expected complexity level and risk 1 # Testing Use the `subscribe` command with a local database and compare server logs before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
subscribecommand would drop the connection without sending aclose frame. Doing so creates a warning on the server, which can be
distracting when debugging other connections issues.
Expected complexity level and risk
1
Testing
Use the
subscribecommand with a local database and compare server logs beforeand after.