Fix AlgebraicTypeLayout::is_compatible_with#2932
Merged
Merged
Conversation
Change `VarLenType::Array` to store `ArrayType` to make similar such bugs impossible in the future.
kim
approved these changes
Jul 11, 2025
Contributor
kim
left a comment
kim
left a comment
There was a problem hiding this comment.
Change to store the inner type seems reasonable to me.
The patch fixes the reported issue.
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix
AlgebraicTypeLayout::is_compatible_with.Change
VarLenType::Arrayto storeArrayTypeto make similar such bugs impossible in the future.
Consequence changes are made to hashing and row serialization to make that work.
This should also benefit performance as there's now one fewer
Boxto look through.API and ABI breaking changes
None
Expected complexity level and risk
3 - fairly central piece of machinery are touched and there's some unsafe code affected.
Testing
A regression test has been added.