Split datastore into its own crate#2933
Merged
Merged
Conversation
Centril
approved these changes
Jul 11, 2025
Centril
left a comment
Centril
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I've highlighted some areas of future improvement. No need to act on any of those now. You can just resolve them to get this merged.
1 task
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR splits the datastore into its own crate. It makes purely mechanical changes to change imports and make things
pubwhich werepub(crate)and necessarily needed to become public. With two exceptions:Lockingtypes rather than associated types in one case.Fromimplementation forHostTypewhich referencesModuleKind, a type unknown to the datastore.API and ABI breaking changes
No API braking changes.
Expected complexity level and risk
1.5 - solely mechanical, but a lot of files touched
Testing
Given the mechanical nature of the changes, I believe our automated tests to be sufficient.