Enable the datastore crate's test feature where necessary#2937
Merged
Conversation
2933 broke running `cargo test` without `--all` because the new `datastore` crate hid some of its test utilities behind `cfg(any(test, feature = "test"))`, but did not enable that feature in the dependency from `core` or `sqltest`. This was hidden in our CI because we run with `--all` there, which apparently enables all optional features, including the `test` feature.
Centril
approved these changes
Jul 14, 2025
bfops
added
release-any
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
#2933 broke running
cargo testwithout--allbecause the newdatastorecrate hid some of its test utilities behindcfg(any(test, feature = "test")), but did not enable that feature in the dependency fromcoreorsqltest.This was hidden in our CI because we run with
--allthere, which apparently enables all optional features, including thetestfeature.API and ABI breaking changes
N/a
Expected complexity level and risk
1
Testing
cargo check --tests --package $PACKAGEfor every crate with a dependency onspacetimedb-datastore(as revealed bygrepfor'spacetimedb-datastore =') and ensured that they all compiled correctly after this patch.