Extract ModuleCommon + use in wasm & v8 runtimes#2940
Merged
Conversation
gefjon
approved these changes
Jul 16, 2025
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Mazdak Farrokhzad <twingoow@gmail.com> Co-authored-by: Phoebe Goldman <phoebe@clockworklabs.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Extract a
struct ModuleCommonwhich holds some common context data for various runtimes.Imbue this new type/module +with common logic and use it in wasm and v8 runtimes.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
No V8 tests yet.
WASM runtime covered by existing tests.