Make websocket configurable via config.toml#2944
Merged
Merged
Conversation
gefjon
approved these changes
Jul 16, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
No objections to this once CI is fixed. Thanks!
Contributor
|
Would appreciate a docs companion PR which updates https://github.com/clockworklabs/spacetime-docs/blob/master/docs/cli-reference/standalone-config.md |
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the websocket configuration pub and arranges for it to be configurable via
the
config.tomlfile.Expected complexity level and risk
1.5
Testing