smoketests: Fix server restarts and make more robust#2977
Merged
Conversation
Smoketests that restart the server became flaky recently as the readiness probing was broken. This patch fixes the issue and makes the process more robust, namely: - Label the compose services to check for readiness (i.e. spacetimedb processes) as `app: spacetimedb`. - When enumerating the containers, consider this label, as well as the current compose file. - Try to "ping" all ports exposed on the host for each spacetimedb container, and succeed if one of them returns 200. Previously, we would assume a specific container port to be "the" spacetimedb port, which became false at some point.
kim
force-pushed
the
kim/smoketests/fix-docker-restart
branch
from
c0f42ad to
42ced60
Compare
jdetter
approved these changes
Jul 23, 2025
Contributor
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
Testing the ping endpoint to see if SpacetimeDB is up rather than just looking at the docxker output seems like it would be a lot more consistent. Thanks Kim, approved with non-blocking question 👍
Shubham8287
pushed a commit
that referenced
this pull request
Jul 28, 2025
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoketests that restart the server became flaky recently as the readiness
probing was broken. This patch fixes the issue and makes the process more
robust, namely:
processes) as
app: spacetimedb.current compose file.
the host and succeed if one of them returns 200.
Previously, we would assume a specific container port to be "the"
spacetimedb port, which became false at some point.
Also re-enable
zz_dockertests.