smoktests: Wait for batched consensus#3010
Merged
Merged
Conversation
Until we have confirmed reads, we need to wait for a tick until any batched commits are flushed. Also cleaned up the code a bit to do less string manipulation of sql results all over the place, and to output less irrelevant logging.
kim
commented
Jul 31, 2025
Shubham8287
approved these changes
Aug 1, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
Until we have confirmed reads, we need to wait for a tick until any batched commits are flushed. Also cleaned up the code a bit to do less string manipulation of sql results all over the place, and to output less irrelevant logging. # Expected complexity level and risk 1 # Testing - [x] yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until we have confirmed reads, we need to wait for a tick until any batched commits are flushed.
Also cleaned up the code a bit to do less string manipulation of sql results all over the place, and to output less irrelevant logging.
Expected complexity level and risk
1
Testing