Implement reduced coupling between SpacetimeDBClient.cs and Table.cs#3122
Merged
Conversation
4 tasks
jdetter
approved these changes
Aug 5, 2025
Contributor
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
LGTM, one small comment on this. Plus the original PR was approved by James as well so this should be fine. Thanks for moving this over 👍
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
…3122) ## Description of Changes Moves table-specific operations out of `SpacetimeDBClient.cs` and into `Table.cs` in order to reduce coupling between the two files. This is the implementation of #3047 This is a PR being duplicated/migrated from clockworklabs/com.clockworklabs.spacetimedbsdk#346, which contains prior discussion/review/approval. ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs No PRs needed, works with latest master ## Testsuite SpacetimeDB branch name: master ## Testing - [X] Opened and ran Blackhol.io within Unity Editor and successfully connecting to a locally running server - [X] Compiled a WebGL build of Blackhol.io and successfully connecting to a locally running server - [x] Opened and ran BitCraft within Unity Editor and successfully connecting to a locally running server
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
…3122) ## Description of Changes Moves table-specific operations out of `SpacetimeDBClient.cs` and into `Table.cs` in order to reduce coupling between the two files. This is the implementation of #3047 This is a PR being duplicated/migrated from clockworklabs/com.clockworklabs.spacetimedbsdk#346, which contains prior discussion/review/approval. ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs No PRs needed, works with latest master ## Testsuite SpacetimeDB branch name: master ## Testing - [X] Opened and ran Blackhol.io within Unity Editor and successfully connecting to a locally running server - [X] Compiled a WebGL build of Blackhol.io and successfully connecting to a locally running server - [x] Opened and ran BitCraft within Unity Editor and successfully connecting to a locally running server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves table-specific operations out of
SpacetimeDBClient.csand intoTable.csin order to reduce coupling between the two files.This is the implementation of #3047
This is a PR being duplicated/migrated from clockworklabs/com.clockworklabs.spacetimedbsdk#346, which contains prior discussion/review/approval.
API
Requires SpacetimeDB PRs
No PRs needed, works with latest master
Testsuite
SpacetimeDB branch name: master
Testing