Drop log for already-compressed snapshot to debug#3131
Merged
Conversation
On databases with many already-compressed snapshots, this was leading to log spam without providing any useful information.
jdetter
approved these changes
Aug 6, 2025
Contributor
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I'm happy with this, I also verified that we're generally running with logging set to info so this should filter this log out.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
On databases with many already-compressed snapshots, this was leading to log spam without providing any useful information.
API and ABI breaking changes
N/a
Expected complexity level and risk
1
Testing
N/a