Added the Unreal SDK work for codegen, testing, and the plugin#3223
Conversation
…uickstartChat example
bfops
force-pushed
the
jlarabie/unreal-sdk-initial
branch
from
081c3c2 to
fba4744
Compare
# Conflicts: # crates/cli/src/subcommands/generate.rs
… + .cpp generation for Unreal Added FrameTick() for SpacetimeDbSdk to match the C# version Fixed Reauth test to store the token outside of UCredentials
# Description of Changes ## Before merging this 1. uncomment the part of the workflow file that overrides `GIT_REF`. This was causing me issues during testing because it somehow kept pulling back in a rolled-back commit from the base branch, but I suspect that this will no longer be true once new commits are added to the base branch. 1. connect a proper GitHub account to an Epic Games account (specifically, an account that multiple people have access to, e.g. maybe all of our devops team) 2. set the `GHCR_SECRET` GH action secret in this repo to be a long-lived PAT for a different account (https://github.com/clockworklabs/SpacetimeDB/settings/secrets/actions). **The current token will expire soon.** 3. Make this check required, I think. # API and ABI breaking changes None. CI-only changes. # Expected complexity level and risk 2 # Testing - [x] The CI runs and seems to pass! --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com> Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com>
|
@bfops - With cargo test --all and this new Unreal set of tests the Test Suites will keep failing. I've updated all the Unreal tests to start with unreal_ to allow for --skip unreal but I'm not sure we should change the Test Suites to --skip unreal? |
Looks like you've already done it but yes I think we should add |
…ve been added by Arvikasoft with AI and the comment is verbose enough
JasonAtClockwork
requested review from
bfops and
cloutiertyler
as code owners
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
my code-owned file (crates/cli/src/subcommands/generate.rs) LGTM, but left several optional nits.
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I'm reviewing the docs for this now. I think this is ready to go in for now and we can fix issues in follow-up PRs as this PR is already quite large and hard to review.
4 participants
Description of Changes
Closes #3219
This adds the Unreal SDK, the new Unreal test cases, updates the test runner to handle Unreal, codegen updates for Unreal, and a QuickStart Chat.
API and ABI breaking changes
No breaking changes.
Expected complexity level and risk
2 - This impacts the subcommand generate.rs to include unrealcpp and crates/testing to expand for Unreal
Testing