Add channel params to commitlog compressor#3254
Merged
joshua-spacetime merged 1 commit intoSep 18, 2025
Merged
Conversation
joshua-spacetime
force-pushed
the
joshua/snapshot_watching_commitlog_compressor
branch
2 times, most recently
from
b334edb to
40e798b
Compare
joshua-spacetime
force-pushed
the
joshua/snapshot_watching_commitlog_compressor
branch
from
40e798b to
d5d7c55
Compare
joshua-spacetime
changed the title
joshua-spacetime
deleted the
joshua/snapshot_watching_commitlog_compressor
branch
joshua-spacetime
added a commit
that referenced
this pull request
Sep 18, 2025
# Description of Changes <!-- Please describe your change, mention any related tickets, and so on here. --> In order to facilitate commitlog and snapshot archival, this patch adds channel params to `snapshot_watching_commitlog_compressor` # API and ABI breaking changes <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> None # Expected complexity level and risk <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> 1 # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
In order to facilitate commitlog and snapshot archival, this patch adds channel params to
snapshot_watching_commitlog_compressorAPI and ABI breaking changes
None
Expected complexity level and risk
1
Testing