Fix to Unreal tests to stop requesting infinite resources#3504
Merged
Conversation
Collaborator
|
Does that mean that we only see the |
Contributor
Author
This is actually before anything has run in Unreal, on the Linux initialization it runs a IncreasePerProcessLimits() before allowing the internal GuardedMain() from processing. It does mean we won't get Unreal core dumps if something goes wrong in CI but if it goes that badly wrong with a test we should see it in a lower environment first. It will still output all errors that happened which is 90% of the time enough to resolve any troubles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
For core dumps Unreal tries to use setrlimit() for infinity when setting resource limits, it seems this becomes an issue intermittently when running tests in parallel. There is an option when running Unreal to disable this and we can rely on error longs only which makes sense for CI imo.
API and ABI breaking changes
None
Expected complexity level and risk
1 - small flag change
Testing