CI - Skip Internal Tests and Unreal Tests on external PRs#3522
Merged
Conversation
jdetter
approved these changes
Oct 28, 2025
Contributor
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
This seems good to me, will this cause issues when we make Internal Tests required in the future?
Collaborator
Author
Yes, but currently it fails, so that's not any better. |
Contributor
Fair! 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
These tests fail on external PRs, but not for any real reasons - just because GH secrets are missing. "Skipped" is more informative than "failed".
API and ABI breaking changes
None.
Expected complexity level and risk
1
Testing
None, but I just copied the logic from the unity testsuite.