Skip to content

C# release changes for cargo release #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdetter wants to merge 17 commits into from
+12 −11
Closed

C# release changes for cargo release #3648

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0e8c87a
Changes for `cargo release`
jdetter Nov 26, 2025
a1e9f8c
Improve CI check
jdetter Nov 26, 2025
a6f68ca
Ignore meta files
jdetter Nov 26, 2025
05b5f60
Merge branch 'master' into jdetter/csharp-release-changes
jdetter Nov 26, 2025
6f28b3e
Update sdks/csharp/release~/spacetimedb.bsatn.runtime/unversioned/.gi…
jdetter Nov 26, 2025
8c2472d
Update sdks/csharp/release~/.gitignore
jdetter Nov 26, 2025
57a5531
Remove old package
jdetter Nov 26, 2025
48ccf41
Merge branch 'jdetter/csharp-release-changes' of ssh://github.com/clo…
jdetter Nov 26, 2025
fe4d9e9
Moved packages under release~
jdetter Nov 26, 2025
390211e
Merge branch 'master' into jdetter/csharp-release-changes
jdetter Nov 27, 2025
a0541ac
Merge tag 'v1.11.0' into jdetter/csharp-release-changes
jdetter Dec 8, 2025
ac7744f
Move gitignore file
jdetter Dec 8, 2025
d3114c3
Remove unused gitignore file
jdetter Dec 8, 2025
ae2a3f7
Update typescript package size limits (#3854)
jdetter Dec 9, 2025
bbfa851
Release v1.11.1
jdetter Dec 18, 2025
8fbd9ac
Merge tag 'v1.11.1' into jdetter/csharp-release-changes
jdetter Dec 18, 2025
ff52259
Update .gitignore
jdetter Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/bindings-typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
"name": "sdk esm min (brotli)",
"path": "dist/min/sdk/index.browser.mjs",
"brotli": true,
"limit": "14 kB"
"limit": "30 kB"
},
{
"name": "sdk esm min (gzip)",
Expand All @@ -148,7 +148,7 @@
{
"name": "sdk esm min (uncompressed)",
"path": "dist/min/sdk/index.browser.mjs",
"limit": "14 kB"
"limit": "30 kB"
Copy link
Copy Markdown
Collaborator

@bfops bfops Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated? maybe a merge of master will fix this?

}
],
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions sdks/csharp/.meta-check-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
release~
11 changes: 0 additions & 11 deletions sdks/csharp/packages/.gitignore
View file
Open in desktop

This file was deleted.

Binary file removed ...ackages/spacetimedb.bsatn.runtime/1.5.0/analyzers/dotnet/cs/SpacetimeDB.BSATN.Codegen.dll
View file
Open in desktop
Binary file not shown.
Binary file removed ...packages/spacetimedb.bsatn.runtime/1.5.0/lib/netstandard2.1/SpacetimeDB.BSATN.Runtime.dll
View file
Open in desktop
Binary file not shown.
0 sdks/csharp/packages.meta → sdks/csharp/release~/packages.meta
View file
Open in desktop
File renamed without changes.
0 ...p/packages/spacetimedb.bsatn.runtime.meta → ...~/packages/spacetimedb.bsatn.runtime.meta
View file
Open in desktop
File renamed without changes.
0 ...ages/spacetimedb.bsatn.runtime/1.5.0.meta → ...pacetimedb.bsatn.runtime/unversioned.meta
View file
Open in desktop
File renamed without changes.
8 changes: 8 additions & 0 deletions sdks/csharp/release~/packages/spacetimedb.bsatn.runtime/unversioned/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
.nupkg.metadata
.signature.p7s
LICENSE
README.md
logo.png
spacetimedb.bsatn.runtime.*.nupkg*
spacetimedb.bsatn.runtime.nuspec
*.xml
Copy link
Copy Markdown
Collaborator

@bfops bfops Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an aside.. to we expect any of these files to actually appear down here?

Copy link
Copy Markdown
Contributor Author

@jdetter jdetter Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they do appear due to dotnet restore. Essentially these files end up in the packages/spacetimedb.bsatn.runtime/vX.Y.Z directory. During the csharp release we copy the unversioned directory on top of the directory that contains these files.

Right now when we do the C# release we are just doing a git add on the packages directory, we could manually git add each individual file instead but I think it's possible that might be more fragile? I'm not sure, I'm not highly invested into either approach here.

Copy link
Copy Markdown
Collaborator

@bfops bfops Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that makes sense. Can we add something like this as a comment?

(that said, I'm surprised that things like LICENSE, logo.png, and README.md show up.. but it also doesn't matter too much)

Copy link
Copy Markdown
Contributor Author

@jdetter jdetter Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the LICENSE, logo.png and README.md files show up because of how dotnet pack works, for some reason those files are included when packing 🤷 .

0 ...timedb.bsatn.runtime/1.5.0/analyzers.meta → ....bsatn.runtime/unversioned/analyzers.meta
View file
Open in desktop
File renamed without changes.
0 ...bsatn.runtime/1.5.0/analyzers/dotnet.meta → ...runtime/unversioned/analyzers/dotnet.meta
View file
Open in desktop
File renamed without changes.
0 ...tn.runtime/1.5.0/analyzers/dotnet/cs.meta → ...time/unversioned/analyzers/dotnet/cs.meta
View file
Open in desktop
File renamed without changes.
0 ...net/cs/SpacetimeDB.BSATN.Codegen.dll.meta → ...net/cs/SpacetimeDB.BSATN.Codegen.dll.meta
View file
Open in desktop
File renamed without changes.
0 .../spacetimedb.bsatn.runtime/1.5.0/lib.meta → ...timedb.bsatn.runtime/unversioned/lib.meta
View file
Open in desktop
File renamed without changes.
0 ...atn.runtime/1.5.0/lib/netstandard2.1.meta → ...ntime/unversioned/lib/netstandard2.1.meta
View file
Open in desktop
File renamed without changes.
0 ...ard2.1/SpacetimeDB.BSATN.Runtime.dll.meta → ...ard2.1/SpacetimeDB.BSATN.Runtime.dll.meta
View file
Open in desktop
File renamed without changes.
Loading