Skip to content

Don't block worker thread waiting for SQL transaction #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kim wants to merge 1 commit into from
Closed

Don't block worker thread waiting for SQL transaction #3885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions crates/core/src/sql/execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ use crate::host::{ArgsTuple, ModuleHost};
use crate::subscription::module_subscription_actor::{commit_and_broadcast_event, ModuleSubscriptions};
use crate::subscription::module_subscription_manager::TransactionOffset;
use crate::subscription::tx::DeltaTx;
use crate::util::asyncify;
use crate::util::slow::SlowQueryLogger;
use crate::vm::{check_row_limit, DbProgram, TxMode};
use anyhow::anyhow;
Expand Down Expand Up @@ -197,9 +198,16 @@ pub async fn run(
) -> Result<SqlResult, DBError> {
// We parse the sql statement in a mutable transaction.
// If it turns out to be a query, we downgrade the tx.
let (tx, stmt) = db.with_auto_rollback(db.begin_mut_tx(IsolationLevel::Serializable, Workload::Sql), |tx| {
compile_sql_stmt(sql_text, &SchemaViewer::new(tx, &auth), &auth)
})?;
let (tx, stmt) = {
// Ensure lock acquisition doesn't block a worker thread.
let tx = asyncify({
let db = db.clone();
move || db.begin_mut_tx(IsolationLevel::Serializable, Workload::Sql)
})
.await;
let stmt = compile_sql_stmt(sql_text, &SchemaViewer::new(&tx, &auth), &auth);
db.rollback_on_err(tx, stmt)
}?;

let mut metrics = ExecutionMetrics::default();

Expand Down
Loading