Skip to content

fix: Replace unwrap with proper error handling in set_domains handler #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfops merged 3 commits into from
Mar 19, 2026
+6 −1
Merged

fix: Replace unwrap with proper error handling in set_domains handler #4643

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1210b2
fix: Replace unwrap with proper error handling in set_domains handler
Shiven0504 Mar 16, 2026
6339a26
Merge branch 'master' into fix/set-domains-unwrap-panic
bfops Mar 18, 2026
473b192
[fix/set-domains-unwrap-panic]: fix lint
bfops Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/client-api/src/routes/database.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,7 @@ pub async fn set_names<S: ControlStateDelegate + Authorization>(
})?;

for name in &validated_names {
if ctx.lookup_database_identity(name.as_str()).await.unwrap().is_some() {
if ctx.lookup_database_identity(name.as_str()).await.map_err(log_and_500)?.is_some() {
return Ok((
StatusCode::BAD_REQUEST,
axum::Json(name::SetDomainsResult::OtherError(format!(
Expand Down
Loading