Enable --native-aot flag during spacetime init and spacetime publish for NativeAOT-LLVM support#4672
Merged
rekhoff merged 22 commits intoApr 20, 2026
Conversation
jdetter
reviewed
Mar 25, 2026
Contributor
jdetter
left a comment
There was a problem hiding this comment.
Just a few things for now - I ran into the issue that I DM'd you about so I'll do another review pass later today
Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
…f/update-nativeaot-llvm-infrastructure
…odule-path` is used
…ables `NativeAOT-LLVM` IL scanner fails to compute `vtables` for `TaggedEnum<T>` types when they're only referenced indirectly (e.g., through generated `Equals` methods). This caused publish failures for modules with no tables having indexes/primary keys. Fix: Add type rooting in `Module.__describe_module__` to ensure all `TaggedEnum` subtypes are processed by the IL scanner.
…f/update-nativeaot-llvm-infrastructure
…f/update-nativeaot-llvm-infrastructure
jdetter
reviewed
Apr 16, 2026
Contributor
jdetter
left a comment
There was a problem hiding this comment.
Just a few things for now, I'm going to test against a new system to see what we get
jdetter
approved these changes
Apr 20, 2026
Contributor
jdetter
left a comment
There was a problem hiding this comment.
Tested, working. Code looks good as well, thanks for all of the help getting the testing working on this Ryan 🙏
5893f67
into
tyler/update-nativeaot-llvm-infrastructure
51 of 57 checks passed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds
--native-aotflag tospacetime initcommand for creating NativeAOT-LLVM enabled C# projects. This automatically adds the required LLVM package references to the generated.csprojfile and sets"native-aot": trueinspacetime.json.This also adds
--native-aotflag tospacetime publish. This is optional because the developer will still need to add the required LLVM package references to their.csprojfile, and the provided instructions also include adding"native-aot": trueto theirspacetime.jsonwhich will already apply the flag.API and ABI breaking changes
None.
Expected complexity level and risk
1 (Low). Adds new optional flag to init command and post-processing of generated .csproj files.
Testing
spacetime init --lang csharp --native-aotcreates projects with required LLVM package referencesspacetime.jsonis generated with"native-aot": true--native-aotflag andspacetime.jsonconfiguration