Compression stats and commitlog compression function#4708
Merged
Conversation
Namely, bytes in + bytes out. Apart from metrics, we want to use this for throttling I/O when necessary.
kim
changed the title
kim
force-pushed
the
kim/compression-stats
branch
from
62d9203 to
4a97348
Compare
cloutiertyler
approved these changes
Apr 28, 2026
cloutiertyler
left a comment
cloutiertyler
left a comment
Contributor
There was a problem hiding this comment.
No objection to this.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a way to pass a "closure" when compressing a commitlog segment, such that the source and destination are polymorphic. This allows to have them wrapped externally, which is used to apply bandwidth limiting where necessary.
Also return bytes in + bytes out stats from the compressor.
Expected complexity level and risk
1
Testing
Elsewhere.