Skip to content

More granular table traits #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clockwork-labs-bot merged 11 commits into from
Jun 30, 2026
Merged

More granular table traits #4775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8171276
without breaking changes
onx2 May 16, 2026
f7848e2
Merge branch 'master' into onx2/table-traits
bfops Jun 29, 2026
b170fc0
Regenerate Rust SDK test bindings
clockwork-labs-bot Jun 29, 2026
e5ce441
Merge remote-tracking branch 'origin/master' into onx2/table-traits
clockwork-labs-bot Jun 29, 2026
b41dd48
Merge remote-tracking branch 'origin/master' into onx2/table-traits
clockwork-labs-bot Jun 29, 2026
dff6c28
Regenerate case conversion SDK bindings
clockwork-labs-bot Jun 30, 2026
f15655d
Regenerate Rust SDK test-client bindings
clockwork-labs-bot Jun 30, 2026
2449167
Regenerate final Rust SDK bindings
clockwork-labs-bot Jun 30, 2026
e9885f9
Regenerate stable Rust SDK bindings
clockwork-labs-bot Jun 30, 2026
f3ba141
Regenerate Rust test client bindings
clockwork-labs-bot Jun 30, 2026
c3185d7
Apply final Rust test client bindings
clockwork-labs-bot Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bindings-typescript/case-conversion-test-client/src/module_bindings/index.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

76 changes: 76 additions & 0 deletions crates/codegen/src/rust.rs
View file
Open in desktop
Comment thread
onx2 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,14 @@ pub struct {insert_callback_id}(__sdk::CallbackId);
write!(
out,
"
impl<'ctx> __sdk::TableLike for {table_handle}<'ctx> {{
type Row = {row_type};
type EventContext = super::EventContext;

fn count(&self) -> u64 {{ self.imp.count() }}
fn iter(&self) -> impl Iterator<Item = {row_type}> + '_ {{ self.imp.iter() }}
}}

impl<'ctx> __sdk::EventTable for {table_handle}<'ctx> {{
type Row = {row_type};
type EventContext = super::EventContext;
Expand All @@ -203,6 +211,21 @@ impl<'ctx> __sdk::EventTable for {table_handle}<'ctx> {{
self.imp.remove_on_insert(callback.0)
}}
}}

impl<'ctx> __sdk::WithInsert for {table_handle}<'ctx> {{
type InsertCallbackId = {insert_callback_id};

fn on_insert(
&self,
callback: impl FnMut(&Self::EventContext, &Self::Row) + Send + 'static,
) -> {insert_callback_id} {{
{insert_callback_id}(self.imp.on_insert(Box::new(callback)))
}}

fn remove_on_insert(&self, callback: {insert_callback_id}) {{
self.imp.remove_on_insert(callback.0)
}}
}}
"
);
} else {
Expand All @@ -213,6 +236,14 @@ impl<'ctx> __sdk::EventTable for {table_handle}<'ctx> {{
out,
"pub struct {delete_callback_id}(__sdk::CallbackId);

impl<'ctx> __sdk::TableLike for {table_handle}<'ctx> {{
type Row = {row_type};
type EventContext = super::EventContext;

fn count(&self) -> u64 {{ self.imp.count() }}
fn iter(&self) -> impl Iterator<Item = {row_type}> + '_ {{ self.imp.iter() }}
}}

impl<'ctx> __sdk::Table for {table_handle}<'ctx> {{
type Row = {row_type};
type EventContext = super::EventContext;
Expand Down Expand Up @@ -246,6 +277,36 @@ impl<'ctx> __sdk::Table for {table_handle}<'ctx> {{
self.imp.remove_on_delete(callback.0)
}}
}}

impl<'ctx> __sdk::WithInsert for {table_handle}<'ctx> {{
type InsertCallbackId = {insert_callback_id};

fn on_insert(
&self,
callback: impl FnMut(&Self::EventContext, &Self::Row) + Send + 'static,
) -> {insert_callback_id} {{
{insert_callback_id}(self.imp.on_insert(Box::new(callback)))
}}

fn remove_on_insert(&self, callback: {insert_callback_id}) {{
self.imp.remove_on_insert(callback.0)
}}
}}

impl<'ctx> __sdk::WithDelete for {table_handle}<'ctx> {{
type DeleteCallbackId = {delete_callback_id};

fn on_delete(
&self,
callback: impl FnMut(&Self::EventContext, &Self::Row) + Send + 'static,
) -> {delete_callback_id} {{
{delete_callback_id}(self.imp.on_delete(Box::new(callback)))
}}

fn remove_on_delete(&self, callback: {delete_callback_id}) {{
self.imp.remove_on_delete(callback.0)
}}
}}
"
);

Expand All @@ -272,6 +333,21 @@ impl<'ctx> __sdk::TableWithPrimaryKey for {table_handle}<'ctx> {{
self.imp.remove_on_update(callback.0)
}}
}}

impl<'ctx> __sdk::WithUpdate for {table_handle}<'ctx> {{
type UpdateCallbackId = {update_callback_id};

fn on_update(
&self,
callback: impl FnMut(&Self::EventContext, &Self::Row, &Self::Row) + Send + 'static,
) -> {update_callback_id} {{
{update_callback_id}(self.imp.on_update(Box::new(callback)))
}}

fn remove_on_update(&self, callback: {update_callback_id}) {{
self.imp.remove_on_update(callback.0)
}}
}}
"
);
}
Expand Down
Loading
Loading