Fix index schema from st tables.#5145
Open
Shubham8287 wants to merge 7 commits into
Open
Conversation
Shubham8287
changed the title
Shubham8287
force-pushed
the
shub/fix-table-migration-index
branch
from
6191d7c to
7e41705
Compare
Shubham8287
changed the title
Shubham8287
changed the title
Shubham8287
force-pushed
the
shub/fix-table-migration-index
branch
from
e8fb6cc to
e2a1966
Compare
| ); | ||
|
|
||
| const spacetimedb = schema({ | ||
| renamedUsers, |
Contributor
There was a problem hiding this comment.
This renames the table accessor too. We're migrating st_index_accessor, but what about st_table_accessor?
Contributor
Author
There was a problem hiding this comment.
I think I should fix accessor name changes in separate PR, as that change requires more thorough considerations.
I am keeping the current PR to fix building correct IndexSchema from sys tables, Which will unblock the table migration path. As people will run into table migration more frequently than changing accessor name especially during Hackothon
Contributor
There was a problem hiding this comment.
That sounds reasonable to me.
joshua-spacetime
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
fixes #4701.
IndexSchemawhen build from system tables, wasn't consideringst_index_accessortable to set alias.API and ABI breaking changes
NA
Expected complexity level and risk
2.5
Testing
Added a smoketest for typescript, this is more apparent in typescript due to
snake_casename casing results in different canonical and accessor name.