From 713596e8954f722b7a0cf993019ae6dd106b1f00 Mon Sep 17 00:00:00 2001 From: Zeke Foppa Date: Sun, 31 May 2026 17:33:15 -0700 Subject: [PATCH] CI - Remove stale commented-out code --- .github/workflows/ci.yml | 64 ---------------------------------------- 1 file changed, 64 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0501219dddb..6822f0d648b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1040,31 +1040,6 @@ jobs: restore-keys: | ${{ runner.os }}-pnpm-store- - # - name: Extract SpacetimeDB branch name from file - # id: extract-branch - # run: | - # # Define the path to the branch file - # BRANCH_FILE=".github/spacetimedb-branch.txt" - - # # Default to master if file doesn't exist - # if [ ! -f "$BRANCH_FILE" ]; then - # echo "::notice::No SpacetimeDB branch file found, using 'master'" - # echo "branch=master" >> $GITHUB_OUTPUT - # exit 0 - # fi - - # # Read and trim whitespace from the file - # branch=$(cat "$BRANCH_FILE" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') - - # # Fallback to master if empty - # if [ -z "$branch" ]; then - # echo "::warning::SpacetimeDB branch file is empty, using 'master'" - # branch="master" - # fi - - # echo "branch=$branch" >> $GITHUB_OUTPUT - # echo "Using SpacetimeDB branch from file: $branch" - - name: Install Rust toolchain uses: dsherret/rust-toolchain-file@v1 - name: Set default rust toolchain @@ -1079,48 +1054,9 @@ jobs: save-if: false prefix-key: v1 - # # This step shouldn't be needed, but somehow we end up with caches that are missing librusty_v8.a. - # # ChatGPT suspects that this could be due to different build invocations using the same target dir, - # # and this makes sense to me because we only see it in this job where we mix `cargo build -p` with - # # `cargo build --manifest-path` (which apparently build different dependency trees). - # # However, we've been unable to fix it so... /shrug - # - name: Check v8 outputs - # run: | - # find "${CARGO_TARGET_DIR}"/ -type f | grep '[/_]v8' || true - # if ! [ -f "${CARGO_TARGET_DIR}"/debug/gn_out/obj/librusty_v8.a ]; then - # echo "Could not find v8 output file librusty_v8.a; rebuilding manually." - # cargo clean -p v8 || true - # cargo build -p v8 - # fi - # if ! [ -f "${CARGO_TARGET_DIR}"/release/gn_out/obj/librusty_v8.a ]; then - # echo "Could not find v8 output file librusty_v8.a; rebuilding manually." - # cargo clean --release -p v8 || true - # cargo build --release -p v8 - # fi - - # - name: Install SpacetimeDB CLI from the local checkout - # run: | - # export CARGO_HOME="$HOME/.cargo" - # echo "$CARGO_HOME/bin" >> "$GITHUB_PATH" - # cargo install --force --path crates/cli --locked --message-format=short - # cargo install --force --path crates/standalone --locked --message-format=short - # # Add a handy alias using the old binary name, so that we don't have to rewrite all scripts (incl. in submodules). - # ln -sf $CARGO_HOME/bin/spacetimedb-cli $CARGO_HOME/bin/spacetime - # # Clear any existing information - # spacetime server clear -y - - name: Run TypeScript tests run: cargo ci typescript-test - # - name: Run quickstart-chat tests - # working-directory: examples/quickstart-chat - # run: pnpm test - # - # # Run this step always, even if the previous steps fail - # - name: Print rows in the user table - # if: always() - # run: spacetime sql quickstart-chat "SELECT * FROM user" - version_upgrade_check: runs-on: spacetimedb-new-runner-2 steps: