Capture cpu profile for keynote bench in nightly job#5163
Open
joshua-spacetime wants to merge 2 commits into
Open
Capture cpu profile for keynote bench in nightly job#5163joshua-spacetime wants to merge 2 commits into
joshua-spacetime wants to merge 2 commits into
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
joshua-spacetime
commented
Jun 2, 2026
joshua-spacetime
commented
Jun 2, 2026
Contributor
|
I'd like @jdetter to review this one. |
joshua-spacetime
commented
Jun 2, 2026
| name: keynote-bench-nightly-profile | ||
| path: ${{ env.KEYNOTE_PROFILE_DIR }} | ||
| if-no-files-found: warn | ||
| retention-days: 90 |
Contributor
Author
There was a problem hiding this comment.
Note for @jdetter: I'm not sure if or how much of an impact this will have on our github actions spend. Happy to reconfigure this. I would just like some level of cpu profile history for diagnostic purposes.
joshua-spacetime
force-pushed
the
joshua/samply-keynote-bench
branch
from
4293798 to
e6e1c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Also capture a cpu profile on a keynote bench job failure.
API and ABI breaking changes
N/A
Expected complexity level and risk
2
Testing