[NS 4] TypeScript: codegen and SDK support for module mounts#5170
Open
aasoni wants to merge 1 commit into
Open
Conversation
f6591d8 to
f7a7693
Compare
6870b0c to
f075552
Compare
f7a7693 to
be4574a
Compare
f075552 to
3b6080d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Generate typescript client module bindings for mounted sub-modules. To avoid file name conflicts mounted code gen files are generated inside folders named after the mount's namespace. This is done recursively so folders containing client bindings for mounted types can in turn contain folders for mounted types.
API and ABI breaking changes
No
Expected complexity level and risk
3 - Code change is not overly complicated, and the risk not deemed to high as the change only applies to mounted types.
Testing
This set of of manual tests were done on the complete set of changes for namespaces, which includes 6 PRs.
Module:
Client
CLI
Migration
Commit Log