[NS 5] CLI: namespace support for spacetime call and spacetime sql#5171
Open
aasoni wants to merge 1 commit into
Open
Conversation
cloutiertyler
approved these changes
Jun 2, 2026
| } | ||
|
|
||
| pub async fn call(&self, reducer_name: &str, arg_json: String) -> anyhow::Result<reqwest::Response> { | ||
| let encoded = reducer_name.replace('/', "%2F"); |
Contributor
There was a problem hiding this comment.
Is this supposed to be a . or a /?
Contributor
Author
There was a problem hiding this comment.
I think "/" is correct. When calling a reducer or procedure the proposal said the namespace separating character is "/"
6870b0c to
f075552
Compare
fe0654d to
a284b57
Compare
a284b57 to
e54ed46
Compare
f075552 to
3b6080d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Allow CLI commands to handle calls to namespaced reducers (e.g.
spacetime call module lib.library_reducer) and query namespaced talbes (e.g.spacetime sql 'select * from lib.library_table)API and ABI breaking changes
No
Expected complexity level and risk
2 - Change if fairly small and straightforward.
Testing
Tests performed on a sample module with mounts: