[NS 6] Migrations: handle mounted submodule tables, views, and indexes#5174
Open
aasoni wants to merge 1 commit into
Open
Conversation
fe0654d to
a284b57
Compare
2dfc6d4 to
be36425
Compare
a284b57 to
e54ed46
Compare
be36425 to
4fb542f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Handle module migrations for modules that have mounted sub-modules. This required major surgery on the the migration step types which used "Identifier" which doesn't allow for dots or slashes.
It also required significant changes in the code that gathers and compares changes between the old and new module to correctly compare namespaced types with the corresponding mounted types.
API and ABI breaking changes
No
Expected complexity level and risk
4 - Significant change to migration code and logic. This shouldn't effect any logic for migrations that affect modules that don't have mounts, but the change is extensive enough that I think 4 is warrented.
Testing
Beyond the rust tests in the codebase that test various auto-migration cases for mounted modules I also did the following tests on sample module that had a mounted sub-module library: