Fix Internal Tests paths filter checkout#5295
Merged
Merged
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
bfops
reviewed
Jun 16, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
approved these changes
Jun 16, 2026
bfops
left a comment
bfops
left a comment
Collaborator
There was a problem hiding this comment.
oops forgot to approve. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds an explicit checkout step before
dorny/paths-filterin the Internal Tests workflow.Why
dorny/paths-filter@v3needs a git working tree forpushevents. The Internal Tests workflow ran it before any checkout, so everypushrun onmasterfailed immediately inDetect non-docs changeswith:This only showed up consistently on
masterbecause those runs arepushevents. Onpull_requestevents,dorny/paths-filtercan use the GitHub pull request files API with the PR number, so it does not need a local checkout for the same file detection path.Adding checkout gives the action a repository when it handles
pushevents, while leaving PR behavior unchanged.Testing
git diff --checkInternal Testsjob completedCheckoutandDetect non-docs changessuccessfully, then moved on to private dispatch/wait.